Hi Doug, I will add your patch and your name in signed-off-by. Is that appropriate? Best regards, Jung **************************************** ??????????? (Rockchip) ?? (Jung Zhao) ????? (Algorithm Engineer) +86-591-83991906-8944 **************************************** -----????----- ???: dianders at google.com [mailto:dianders at google.com] ?? Doug Anderson ????: 2016?2?18? 0:18 ???: Jung Zhao ??: Tomasz Figa; Pawel Osciak; Mauro Carvalho Chehab; Hans Verkuil; Laurent Pinchart; Guennadi Liakhovetski; Philipp Zabel; open list:ARM/Rockchip SoC...; Linux Media Mailing List ??: Re: [PATCH v2 4/4] media: vcodec: rockchip: Add Rockchip VP8 decoder driver Hello, On Wed, Feb 17, 2016 at 2:43 AM, Jung Zhao <jung.zhao at rock-chips.com> wrote: > + dma_set_attr(DMA_ATTR_NO_KERNEL_MAPPING, &attrs_novm); > + vpu->alloc_ctx = vb2_dma_contig_init_ctx_attrs(&pdev->dev, > + &attrs_novm); > + if (IS_ERR(vpu->alloc_ctx)) { > + ret = PTR_ERR(vpu->alloc_ctx); > + goto err_dma_contig; > + } > + > + vpu->alloc_ctx_vm = vb2_dma_contig_init_ctx(&pdev->dev); > + if (IS_ERR(vpu->alloc_ctx_vm)) { > + ret = PTR_ERR(vpu->alloc_ctx_vm); > + goto err_dma_contig_vm; > + } I'm not qualified to review this whole driver, so just adding my $0.02... Could you please fold <https://chromium-review.googlesource.com/322336> into your patch submission? All of the necessary patches have landed in RMK's tree upstream and are currently present in linuxnext. Thanks! -Doug
