On 16.11.2015 12:06, Masahiro Yamada wrote: > Many ARM sub-architectures use prompts followed by "if" conditional, > but it is wrong. > > Please notice the difference between > > config ARCH_FOO > bool "Foo SoCs" if ARCH_MULTI_V7 > > and > > config ARCH_FOO > bool "Foo SoCs" > depends on ARCH_MULTI_V7 > > These two are *not* equivalent! > > In the former statement, it is not ARCH_FOO, but its prompt that > depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO > is selected by another, but ARCH_MULTI_V7 is still disabled. As it is > not unmet dependency, Kconfig never warns. This is probably not what > you want. > > The former should be used only when you need to do so, and you really > understand what you are doing. (In most cases, it should be wrong!) > > For enabling/disabling sub-architectures, the latter is always correct. > > As a good side effect, this commit fixes some entries over 80 columns > (mach-imx, mach-integrator, mach-mbevu). > > Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com> > --- > > I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML > because the correct understanding of Kconfig is required for this patch. > > > arch/arm/Kconfig | 3 ++- > arch/arm/mach-alpine/Kconfig | 3 ++- > arch/arm/mach-at91/Kconfig | 15 ++++++++++----- > arch/arm/mach-axxia/Kconfig | 3 ++- > arch/arm/mach-bcm/Kconfig | 27 ++++++++++++++++++--------- > arch/arm/mach-berlin/Kconfig | 3 ++- > arch/arm/mach-cns3xxx/Kconfig | 3 ++- > arch/arm/mach-exynos/Kconfig | 3 ++- > arch/arm/mach-highbank/Kconfig | 3 ++- > arch/arm/mach-hisi/Kconfig | 12 ++++++++---- > arch/arm/mach-imx/Kconfig | 6 ++++-- > arch/arm/mach-integrator/Kconfig | 3 ++- > arch/arm/mach-mediatek/Kconfig | 3 ++- > arch/arm/mach-meson/Kconfig | 3 ++- > arch/arm/mach-moxart/Kconfig | 3 ++- > arch/arm/mach-mvebu/Kconfig | 24 ++++++++++++++++-------- > arch/arm/mach-picoxcell/Kconfig | 3 ++- > arch/arm/mach-prima2/Kconfig | 3 ++- > arch/arm/mach-qcom/Kconfig | 3 ++- > arch/arm/mach-rockchip/Kconfig | 3 ++- > arch/arm/mach-s5pv210/Kconfig | 3 ++- For Exynos and S5PV210: Acked-by: Krzysztof Kozlowski <k.kozlowski at samsung.com> Best regards, Krzysztof > arch/arm/mach-shmobile/Kconfig | 4 ++-- > arch/arm/mach-socfpga/Kconfig | 3 ++- > arch/arm/mach-spear/Kconfig | 3 ++- > arch/arm/mach-sti/Kconfig | 3 ++- > arch/arm/mach-sunxi/Kconfig | 3 ++- > arch/arm/mach-tegra/Kconfig | 3 ++- > arch/arm/mach-u300/Kconfig | 4 ++-- > arch/arm/mach-ux500/Kconfig | 4 ++-- > arch/arm/mach-vexpress/Kconfig | 3 ++- > arch/arm/mach-zx/Kconfig | 3 ++- > arch/arm/mach-zynq/Kconfig | 3 ++- > 32 files changed, 110 insertions(+), 58 deletions(-) >
