On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
>
> arch/arm/mach-vexpress/Kconfig | 3 ++-
>
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index 10f9389..398a297 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_VEXPRESS
> - bool "ARM Ltd. Versatile Express family" if ARCH_MULTI_V7
> + bool "ARM Ltd. Versatile Express family"
> + depends on ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARCH_SUPPORTS_BIG_ENDIAN
> select ARM_AMBA
For the vexpress part:
Acked-by: Liviu Dudau <Liviu.Dudau at arm.com>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
?\_(?)_/?
