On 2015?07?01? 16:32, Tomasz Figa wrote: > On Wed, Jul 1, 2015 at 5:20 PM, Daniel Vetter <daniel at ffwll.ch> wrote: >> On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote: >>> Hi Mark, >>> >>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao at rock-chips.com> wrote: >>>> Hi Dave. >>>> >>>> Some fixes and some new features. I'd like you can pull them. >>>> >>>> The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898: >>>> >>>> drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000) >>>> >>>> are available in the git repository at: >>>> >>>> https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30 >>>> >>>> for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc: >>>> >>>> drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800) >>>> >>>> ---------------------------------------------------------------- >>>> Heiko St?bner (1): >>>> drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present >>>> >>>> Mark Yao (6): >>>> drm/rockchip: import dma_buf to gem >>>> drm/rockchip: vop: optimize virtual stride calculate >>>> drm/rockchip: vop: fix yuv plane support >>>> drm/rockchip: vop: support plane scale >>>> drm/rockchip: vop: switch cursor plane to window 3 >>>> drm/rockchip: default enable win2/3 area0 bit >>> Has this series been reviewed properly? I can see that at least >>> "drm/rockchip: vop: support plane scale" is kind of "controversial". >> I don't see any discussion of this patch at all on dri-devel, where's this >> controversy? > Well, it adds a lot of seemingly complex, hard to read code with > obvious style issues. I'll review the series later this week. > > Best regards, > Tomasz > > Hi Tomasz Thanks, those compute code you can found from RK3288 TRM->"27.3.3 Win Scaling", too complex. I had do some clean for the code, but for full function and little bug, hard to cleanup. Best regards, -- ?ark
