On 2015?07?01? 16:32, Mark yao wrote: > On 2015?07?01? 16:03, Tomasz Figa wrote: >> Hi Mark, >> >> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao at rock-chips.com> >> wrote: >>> Hi Dave. >>> >>> Some fixes and some new features. I'd like you can pull them. >>> >>> The following changes since commit >>> c5fd936e992dd2829167d2adc63e151675ca6898: >>> >>> drm/nouveau: Pause between setting gpu to D3hot and cutting the >>> power (2015-06-26 10:26:37 +1000) >>> >>> are available in the git repository at: >>> >>> https://github.com/markyzq/kernel-drm-rockchip.git >>> drm-rockchip-2015-06-30 >>> >>> for you to fetch changes up to >>> 5295c05eb30d743987172853179333c80b8242bc: >>> >>> drm/rockchip: default enable win2/3 area0 bit (2015-06-30 >>> 14:24:10 +0800) >>> >>> ---------------------------------------------------------------- >>> Heiko St?bner (1): >>> drm/rockchip: only call drm_fb_helper_hotplug_event if >>> fb_helper present >>> >>> Mark Yao (6): >>> drm/rockchip: import dma_buf to gem >>> drm/rockchip: vop: optimize virtual stride calculate >>> drm/rockchip: vop: fix yuv plane support >>> drm/rockchip: vop: support plane scale >>> drm/rockchip: vop: switch cursor plane to window 3 >>> drm/rockchip: default enable win2/3 area0 bit >> Has this series been reviewed properly? I can see that at least >> "drm/rockchip: vop: support plane scale" is kind of "controversial". > > Sorry for that, can you review those patches, and give me some advices? > > https://lkml.org/lkml/2015/6/18/77 > v2: https://lkml.org/lkml/2015/6/26/192 > >> By the way, if we're using window 3 for cursor plane, because the >> cursor window needs special handling, is it okay to expose the cusor >> window as an overlay plane to userspace, as we do currently? > > special handling? what means? "switch cursor plane to window 3" patch > only switch cursor > windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, > userspace only > can found window 3 is a cursor plane. switch cursor win1 to win3 because we want to use win1 as a overlay for yuv image, win3 not support yuv format. not for special handling. By the way, win3 power power consume less than win1, cursor use win3 would save power. > >> >> Best regards, >> Tomasz >> >> >> > > Best regards, > ?ark > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- ?ark