Linus, On Tue, Oct 28, 2014 at 8:51 AM, Linus Walleij <linus.walleij at linaro.org> wrote: > On Tue, Oct 21, 2014 at 1:27 AM, Doug Anderson <dianders at chromium.org> wrote: > >> The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup >> the .wake_enabled member. That means that we can never actually use a >> pin for wakeup. When "irq_set_irq_wake()" tries to call through it >> will always get a failure from set_irq_wake_real() and will then set >> wake_depth to 0. Assuming you can resume you'll later get an error >> message about "Unbalanced IRQ x wake disable". >> >> Signed-off-by: Doug Anderson <dianders at chromium.org> > > Heiko, are you looking at this patch series? Need you Reviewed-by > to merge this stuff. See Heiko's review on the latest version of this series (v2). https://patchwork.kernel.org/patch/5126811/ https://patchwork.kernel.org/patch/5126941/ https://patchwork.kernel.org/patch/5126971/ https://patchwork.kernel.org/patch/5126801/ -Doug