Chris, On Mon, Oct 27, 2014 at 6:47 AM, Chris Zhong <zyw at rock-chips.com> wrote: > support suspend/resume of pinctrl, it allows handling sleep mode > for hogged pins in pinctrl > > Signed-off-by: Chris Zhong <zyw at rock-chips.com> > > Tested-by: Doug Anderson <dianders at chromium.org> Please no blank lines between tags. I think this has been mentioned before a few times. No need to resend this patch, but please be careful not to keep making this mistake. > --- > > Changes in v5: > - reset-author > - use "__maybe_unused" annotation > > Changes in v4: > - use SIMPLE_DEV_PM_OPS for suspend/resume struct > > Changes in v3: None > Changes in v2: None > > drivers/pinctrl/pinctrl-rockchip.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) This looks right to me now and incorporates all review feedback I'm aware of. Reviewed-by: Doug Anderson <dianders at chromium.org>