On Wed, Oct 22, 2014 at 10:59:59AM +0800, Jianqun wrote: > +config SND_SOC_MAX98090 > + tristate "ASoC support for max98090 driver" > + depends on I2C && GPIOLIB > + help > + Say Y or M here if you want to add support for max98090 codec. No, you're missing what Lars was saying here - there's already a Kconfig symbol for the CODEC in the codecs directory, you should add the help text to that in order to allow the user to enable it. Do this in a separate patch to making your I2S driver selectable since it's not directly related code wise. Please also drop the "ASoC" -> "SoC audio" transition or at least make it a separate patch. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20141022/2bb10004/attachment.sig>