Chris, On Tue, Oct 21, 2014 at 4:25 PM, Chris Zhong <zyw at rock-chips.com> wrote: > @@ -34,7 +40,8 @@ static const char * const rockchip_board_dt_compat[] = { > }; > > DT_MACHINE_START(ROCKCHIP_DT, "Rockchip Cortex-A9 (Device Tree)") > - .l2c_aux_val = 0, > - .l2c_aux_mask = ~0, > + .l2c_aux_val = 0, > + .l2c_aux_mask = ~0, Please avoid unrelated spacing changes. Other than that this is looking like a good starting point. I'm sure we'll find other things to do, but I'd be in favor of landing this and spinning. I can see a device suspend/resume with this patch, so: Tested-by: Doug Anderson <dianders at chromium.org> Reviewed-by: Doug Anderson <dianders at chromium.org>