On Mon, Oct 20, 2014 at 02:31:17PM -0700, Kevin Hilman wrote: > "jinkun.hong" <jinkun.hong at rock-chips.com> writes: > > + spin_lock_irqsave(&pd->idle_lock, flags); > > + val = (idle) ? mask : 0; > > + regmap_update_bits(pd->regmap_pmu, REQ_OFFSET, mask, val); > > + dsb(); > > A summary of the locking and barriers here (or in changelog) would be > helpful for reviewers to verify you're protecting what you need to > protect. It's also worth saying that the Linux specific barrier names should be used unless there is a pressing reason to use the ARM specific barrier names. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
