Chris, On Fri, Oct 17, 2014 at 1:47 PM, <zyw at rock-chips.com> wrote: > From: Chris Zhong <zyw at rock-chips.com> > > It's a basic version of suspend and resume for rockchip, it only support RK3288 > now. > > Signed-off-by: Tony Xie <xxx at rock-chips.com> > Signed-off-by: Chris Zhong <zyw at rock-chips.com> > > --- > > Changes in v2: > - add the regulator calls in prepare and finish. > - add the pinmux of gpio6_c6 save and restore I'm a bit out of time to do a real review right now, but I would have expected that the pinmux stuff: * was saved and restored in the pinmux driver. * was in a separate patch, before this one in the series. The pinmux driver should have callbacks for saving and restoring pinmux state, so you should use those. Maybe exynos_pinctrl_suspend() is an example, though you only need to save one pin. You should probably also explain that only gpio6_c6 needs to be saved and restored since the MaskROM clobbers it upon resume. -Doug
