On Tue, Oct 07, 2014 at 04:43:57PM +0800, Chris Zhong wrote: > @@ -100,6 +132,8 @@ static struct regulator_ops rk808_buck1_2_ops = { > .disable = regulator_disable_regmap, > .is_enabled = regulator_is_enabled_regmap, > .set_ramp_delay = rk808_set_ramp_delay, > + .set_suspend_voltage = rk808_set_suspend_voltage, > + .set_suspend_disable = rk808_set_suspend_disable, > }; Why are there only disable operations, no enable ones? Otherwise this all looks good. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20141007/4c5e8e50/attachment.sig>