On 2014?11?10? 17:53, Zubair Lutfullah Kakakhel wrote:
>
> On 10/11/14 09:44, Andy Yan wrote:
>> Hi ZubairLK
>> On 2014?11?10? 17:17, Zubair Lutfullah Kakakhel wrote:
>>> Nice work.
>>>
>>> This patch should move the binding from
>>>
>>> Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
>>> to the location instead of making a new file and leaving the old
>>> one in place.
>>>
>>> And use git format-patch -M to highlight any changes.
>>>
>>> Regards
>>> ZubairLK
>> I add these bindings for dw-hdmi core, because
>> properities like reg, interrupts, ddc-i2c-bus, reg-io-width are used
>> by dw-hdmi core, but properities like compatible, gpr,clk, are platform
>> specific , they are handled by the platform code like dw_hdmi-imx.c
>> and described in platform specific dt binds like /imx-drm/hdmi.txt
> I understand.
>
> Are there any changes to imx-drm/hdmi.txt?
>
> Some properties for imx-drm/hdmi.txt would become optional/inherited from the parent hdmi drm binding?
>
> The changes should be highlighted in the commit message. Or we'll
> be confused which is which..
>
> ZubairLK
>
to keep compatible for imx, no changes for imx-drm/hdmi.txt
the only added properties is reg-io-width, and it is optional
>>> On 08/11/14 05:32, Andy Yan wrote:
>>>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>>>> ---
>>>> .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++
>>>> 1 file changed, 38 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
>>>> new file mode 100644
>>>> index 0000000..aa7ed17
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
>>>> @@ -0,0 +1,38 @@
>>>> +DesignWare HDMI bridge bindings
>>>> +
>>>> +Required properities:
>>>> +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi"
> spellcheck. compatible
>
>>>> + "rockchip,rk3288-dw-hdmi"
>>>> +- reg: physical base address of the controller and length
>>>> +- ddc-i2c-bus: the ddc i2c bus
>>>> +- interrupts: The interrupt number to the cpu
>>>> +
>>>> +Optional properties
>>>> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present
>>>> +
>>>> +Example:
>>>> + hdmi: hdmi at 0120000 {
>>>> + compatible = "fsl,imx6q-hdmi";
>>>> + reg = <0x00120000 0x9000>;
>>>> + interrupts = <0 115 0x04>;
>>>> + gpr = <&gpr>;
>>>> + clocks = <&clks 123>, <&clks 124>;
>>>> + clock-names = "iahb", "isfr";
>>>> + ddc-i2c-bus = <&i2c2>;
>>>> +
>>>> + port at 0 {
>>>> + reg = <0>;
>>>> +
>>>> + hdmi_mux_0: endpoint {
>>>> + remote-endpoint = <&ipu1_di0_hdmi>;
>>>> + };
>>>> + };
>>>> +
>>>> + port at 1 {
>>>> + reg = <1>;
>>>> +
>>>> + hdmi_mux_1: endpoint {
>>>> + remote-endpoint = <&ipu1_di1_hdmi>;
>>>> + };
>>>> + };
>>>> + };
>>>>
>>>
>>
>
>
