On Wed, 2014-11-05 at 03:56PM +0200, Laurent Pinchart wrote: > Hi Soren, > > Thank you for the patch. > > On Monday 03 November 2014 11:05:26 Soren Brinkmann wrote: > > With the new 'groups' property, the DT parser can infer the map type > > from the fact whether 'pins' or 'groups' is used to specify the pin > > group to work on. > > To maintain backwards compatibitliy with current usage of the DT > > binding, this is only done when an invalid map type is passed to the > > parsing function. > > The Renesas PFC implements similar bindings with using the vendor-specific > properties "renesas,pins" and "renesas,groups" (bindings and implementation > available at Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt > and drivers/pinctrl/sh-pfc/pinctrl.c respectively). > > The Renesas implementation is a bit more generic in that it allows both pins > and groups to be specified in a single subnode. Do you think that feature > would make sense for pinconf-generic as well ? I don't have a use-case for that. I guess if somebody needs this kind of functionality it could be added later. I would like to avoid blocking pinctrl-zynq on adding more features here. Thanks, S?ren