Wolfram, On Thu, Dec 4, 2014 at 10:40 AM, Wolfram Sang <wsa at the-dreams.de> wrote: > >> If you don't read all the below, my belief is that we should simply >> rename the strings in Addy's patch. We should change "rise-ns" to >> "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time". >> Wolfram: can you confirm this is OK? I'm voting to leave the "-ns" >> off the end of both to avoid asymmetry. > > New binding should have the "-ns" suffix, right? So, I'd vote to add the > suffix to the new bindings and deprecate the ones used in the designware > driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns" > > It might be a little more work now, but it will help us in the future, > because it is the correct way to do it. OK, that sounds fair. You're OK with my proposal otherwise? Are you looking for Addy or me to submit a patch supporting the "-ns" suffix on the Designware i2c driver, or should we just use the "-ns" suffix in the Rockchip driver and assume someone will later add support for the new binding in the Designware i2c driver? -Doug