On Fri, Nov 28, 2014 at 2:26 AM, Soren Brinkmann
<soren.brinkmann at xilinx.com> wrote:
> With the new 'groups' property, the DT parser can infer the map type
> from the fact whether 'pins' or 'groups' is used to specify the pin
> group to work on.
> To maintain backwards compatibitliy with current usage of the DT
> binding, this is only done when an invalid map type is passed to the
> parsing function.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann at xilinx.com>
> Tested-by: Andreas F?rber <afaerber at suse.de>
> ---
> Changes since RFC v2:
> - none
OK there are problems with this.
> @@ -264,6 +264,7 @@ int pinconf_generic_dt_subnode_to_map(struct pinctrl_dev *pctldev,
> unsigned reserve;
> struct property *prop;
> const char *group;
> + const char *dt_pin_specifier = "pins";
Something called "dt_pin_specifier" contains the string "pins"...
>
> ret = of_property_read_string(np, "function", &function);
> if (ret < 0) {
> @@ -284,10 +285,20 @@ int pinconf_generic_dt_subnode_to_map(struct pinctrl_dev *pctldev,
> reserve++;
> if (num_configs)
> reserve++;
> +
> ret = of_property_count_strings(np, "pins");
> if (ret < 0) {
> - dev_err(dev, "could not parse property pins\n");
> - goto exit;
> + ret = of_property_count_strings(np, "groups");
> + if (ret < 0) {
> + dev_err(dev, "could not parse property pins/groups\n");
> + goto exit;
> + }
> + if (type == PIN_MAP_TYPE_INVALID)
> + type = PIN_MAP_TYPE_CONFIGS_GROUP;
> + dt_pin_specifier = "groups";
Then suddenly "groups".
The pointer variable should be named something like "subnode_target_type"
or so.
> +++ b/include/linux/pinctrl/pinconf-generic.h
> @@ -174,6 +174,13 @@ static inline int pinconf_generic_dt_node_to_map_pin(
> PIN_MAP_TYPE_CONFIGS_PIN);
> }
>
> +static inline int pinconf_generic_dt_node_to_map_all(
> + struct pinctrl_dev *pctldev, struct device_node *np_config,
> + struct pinctrl_map **map, unsigned *num_maps)
> +{
> + return pinconf_generic_dt_node_to_map(pctldev, np_config, map, num_maps,
> + PIN_MAP_TYPE_INVALID);
> +}
First add some comment describing what happens here and why
INVALID is specified.
Then what does this have to do with the $subject?
Atleast mention in the commit text that a new helper is added, though unused.
Yours,
Linus Walleij
