On Mon, Feb 24 2025 at 13:59, Biju Das wrote: >> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> >> > -#define ICU_TSSR_TSSEL_PREP(tssel, n) ((tssel) << ((n) * 8)) >> > -#define ICU_TSSR_TSSEL_MASK(n) ICU_TSSR_TSSEL_PREP(0x7F, n) >> > +#define ICU_TSSR_TSSEL_PREP(tssel, n, f_width) ((tssel) << ((n) * (f_width))) >> > +#define ICU_TSSR_TSSEL_MASK(n, _field_width) \ >> >> Nit: please use f_width or field_width consistently. > > With field_width there was some alignment issue, that is > the reason it is shortened to f_width. > > If there are no other comments for this patch, I will switch using > field_width in the next version. If this is the only change, then please just post an updated version of _this_ patch (11/12) as a reply to the patch itself. No need to resend the whole series for that cosmetic change, Thanks, tglx