Hi Uwe, > -----Original Message----- > From: Biju Das > Sent: 09 January 2025 09:33 > Subject: RE: [PATCH v23 3/4] pwm: Add support for RZ/G2L GPT > > Hi Uwe, > > Thanks for the feedback. > > > -----Original Message----- > > From: Uwe Kleine-König <ukleinek@xxxxxxxxxx> > > Sent: 09 January 2025 09:23 > > Subject: Re: [PATCH v23 3/4] pwm: Add support for RZ/G2L GPT > > > > Hello Biju, > > > > On Wed, Jan 08, 2025 at 02:13:09PM +0000, Biju Das wrote: > > > Please let me know, if there is any feedback for this patch series > > > or any new API to be adapted in next kernel version which simplifies > > > the code, So that I can send next > > version. > > > > I didn't look, but if you're ambitious you can convert your driver to the waveform callbacks. > > Is it ok, after the acceptance of initial version, will switch to waveform callbacks to enable the > users of GPT(Reason: lot of customers are using GPT for backlight for LCD panels)? > > Please let me know. > > Is there any documentation available for waveform callback? What scenarios we can use Waveform > callbacks compared to traditional one? > > > Otherwise I didn't take a look into this revision yet (also because of the kernel bot message). > > I just need to remove unused variable, that is a simple fix. Gentle ping. Cheers, Biju