On Tue, Dec 10, 2024 at 06:30:41AM +0000, Yoshihiro Shimoda wrote:
> Hello Nikita-san,
>
> > From: Nikita Yushchenko, Sent: Monday, December 9, 2024 5:00 PM
> >
> > MPIC.PIS must be set per phy interface type.
> > MPIC.LSC must be set per speed.
> >
> > Do that strictly per datasheet, instead of hardcoding MPIC.PIS to GMII.
> >
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
>
> Thank you for the patch! I could not apply this patch on net.git / main branch
> and the branch + your patches [1] though, this patch looks good. So,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> [1]
> https://patchwork.kernel.org/project/netdevbpf/list/?series=915669
Hi Nikita,
I agree with Shimoda-san that this does not seem to apply cleanly to net.
Which is a requirement for our CI to run. Please rebase and repost.
--
pw-bot: changes-requested
