Hi Wolfram,
On Thu, Nov 28, 2024 at 9:45 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > + error = register_restart_handler(&clocks->restart_nb);
> >
> > You can simplify using devm_register_sys_off_handler(), cfr.
> > drivers/power/reset/rmobile-reset.c.
>
> Ok, will do, thanks for the pointer. One question, though...
>
> > > + if (error)
> > > + dev_warn(dev, "couldn't register restart handler (%d)\n", error);
>
> rmobile bails out on error. I still think a warning is enough. What is
> your preference?
The mobile-reset driver is only a reset driver, hence failure is fatal.
For a combined clock/reset driver, a warning is fine, IMO.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
