Re: [PATCH] clk: renesas: r9a06g032: add restart handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

> > I got a RZ/N1D now. Before I start the real work, I need working
> > 'reboot' for fluent hacking :)
> 
> Yes, we all do ;-)

Well, previous N1D developers didn't, it seems...

> > +       error = register_restart_handler(&clocks->restart_nb);
> 
> You can simplify using devm_register_sys_off_handler(), cfr.
> drivers/power/reset/rmobile-reset.c.

Ok, will do, thanks for the pointer. One question, though...

> 
> > +       if (error)
> > +               dev_warn(dev, "couldn't register restart handler (%d)\n", error);

rmobile bails out on error. I still think a warning is enough. What is
your preference?

Thanks and happy hacking,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux