Hi Wolfram,
On Thu, Sep 26, 2024 at 9:58 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> (L)BSC should have a "bus" node name together with its register set [1].
> Add the missing names, and change one with a wrong address not matching
> the register space.
Thanks for your patch!
> [1] lbsc: $nodename:0: 'lbsc' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
The "@<unit-address>" part is optional.
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/renesas/r7s72100.dtsi | 2 +-
> arch/arm/boot/dts/renesas/r8a7778.dtsi | 2 +-
> arch/arm/boot/dts/renesas/r8a7779.dtsi | 2 +-
> arch/arm/boot/dts/renesas/r8a7792.dtsi | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/renesas/r7s72100.dtsi b/arch/arm/boot/dts/renesas/r7s72100.dtsi
> index 07ffd9ec96cc..a460a9092c43 100644
> --- a/arch/arm/boot/dts/renesas/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/renesas/r7s72100.dtsi
> @@ -36,7 +36,7 @@ b_clk: b {
> clock-div = <3>;
> };
>
> - bsc: bsc {
> + bsc: bus@3fffc000 {
In the absence of a "reg" property, shouldn't the unit-address match the
"ranges" property?
Actually, I cannot find that in the DT spec, only:
"If the node has no reg property, the @unit-address must be omitted".
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi
> index b80e832c9277..ab0b76eacd3c 100644
> --- a/arch/arm/boot/dts/renesas/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi
> @@ -40,7 +40,7 @@ aliases {
> spi2 = &hspi2;
> };
>
> - bsc: bus@1c000000 {
> + bsc: bus@ff800000 {
"ranges" says 0x1c000000, so the former was correct?
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7779.dtsi b/arch/arm/boot/dts/renesas/r8a7779.dtsi
> index 1944703cba4f..3c5746dbe639 100644
> --- a/arch/arm/boot/dts/renesas/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/renesas/r8a7779.dtsi
> @@ -704,7 +704,7 @@ R8A7779_CLK_MMC1 R8A7779_CLK_MMC0
> };
> };
>
> - lbsc: lbsc {
> + lbsc: bus@ff800000 {
0x1c000000 according to "ranges".
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7792.dtsi b/arch/arm/boot/dts/renesas/r8a7792.dtsi
> index dd3bc32668b7..471a2913e51e 100644
> --- a/arch/arm/boot/dts/renesas/r8a7792.dtsi
> +++ b/arch/arm/boot/dts/renesas/r8a7792.dtsi
> @@ -84,7 +84,7 @@ extal_clk: extal {
> clock-frequency = <0>;
> };
>
> - lbsc: lbsc {
> + lbsc: bus@fec00000 {
0x1c000000 according to "ranges".
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
