Hi Morimoto-san,
On Thu, Jun 27, 2024 at 2:11 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > The use of "Input 1" and "Input 2" sounds a bit strange to me.
> > Looking at sound/soc/codecs/simple-mux.c, these are dictated by the
> > MUX driver.
> (snip)
> > Adding support to simple-audio-mux to override the default "Input 1"
> > and "Input 2" names, using e.g.
> >
> > state-names = "Playback", "Record";
> >
> > would make this more user-friendly.
>
> I have tried to re-use existing driver without fixes.
> but yes, using own naming is better idea.
> I will try to update it, and re-post this patch again.
OK
> > Still, I wonder if there are any side-effects of (ab)using
> > simple-audio-mux for your use case. This MUX driver is really meant
> > to pick one of two sources to connect to a single sink, as described
> > by the topology in simple_mux_dapm_routes[] in the driver. Perhaps
> > there exists software which interpretes these routes, and offers the
> > user a graphical description of the topology, which would be wrong?
>
> If you are talking about detail of direction (IN/OUT vs Playback/Capture),
> indeed it might be a little bit mismatch. But, Playback node and Capture
> node are not shared in general. R-Car Gen4 Sound concept itself is very
> special. So I it not cinderella fit driver but enough driver for this
> purpose. I think there is no *bad* side-effects.
Yes, I mean the assignment of sources and sinks in:
struct snd_soc_dapm_route {
const char *sink;
const char *control;
const char *source;
...
};
static const struct snd_soc_dapm_route simple_mux_dapm_routes[] = {
{ "OUT", NULL, "MUX" },
{ "MUX", "Input 1", "IN1" },
{ "MUX", "Input 2", "IN2" },
};
It looks like snd_soc_dapm_route does not support a node that can
change roles between sink and source.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
