Hi Geert Thank you for your review > The use of "Input 1" and "Input 2" sounds a bit strange to me. > Looking at sound/soc/codecs/simple-mux.c, these are dictated by the > MUX driver. (snip) > Adding support to simple-audio-mux to override the default "Input 1" > and "Input 2" names, using e.g. > > state-names = "Playback", "Record"; > > would make this more user-friendly. I have tried to re-use existing driver without fixes. but yes, using own naming is better idea. I will try to update it, and re-post this patch again. > Still, I wonder if there are any side-effects of (ab)using > simple-audio-mux for your use case. This MUX driver is really meant > to pick one of two sources to connect to a single sink, as described > by the topology in simple_mux_dapm_routes[] in the driver. Perhaps > there exists software which interpretes these routes, and offers the > user a graphical description of the topology, which would be wrong? If you are talking about detail of direction (IN/OUT vs Playback/Capture), indeed it might be a little bit mismatch. But, Playback node and Capture node are not shared in general. R-Car Gen4 Sound concept itself is very special. So I it not cinderella fit driver but enough driver for this purpose. I think there is no *bad* side-effects. Thank you for your help !! Best regards --- Kuninori Morimoto
