Re: [PATCH] checkpatch: really skip LONG_LINE_* when LONG_LINE is ignored

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

On Mon, Jun 10, 2024 at 1:46 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> For this to happen, all types must be set to "show". So, AND is needed
> for the flags, not OR.
>
> Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3858,7 +3858,7 @@ sub process {
>                         }
>
>                         if ($msg_type ne "" &&
> -                           (show_type("LONG_LINE") || show_type($msg_type))) {
> +                           (show_type("LONG_LINE") && show_type($msg_type))) {

I don't know if the change in logic is correct, but if it is, you
probably want to remove one set of parentheses:
A && (B && C) => A && B && C

>                                 my $msg_level = \&WARN;
>                                 $msg_level = \&CHK if ($file);
>                                 &{$msg_level}($msg_type,

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds