RE: [PATCH 1/2] arm64: dts: renesas: r8a779g0: Add PCIe Host and Endpoint nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Thursday, April 25, 2024 4:21 PM
> 
> Hi Shimoda-san,
> 
> On Thu, Mar 14, 2024 at 2:56 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > On Thu, Feb 29, 2024 at 1:07 PM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > Add PCIe Host and Endpoint nodes for R-Car V4H (R8A779G0).
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> > > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> > > @@ -723,6 +737,126 @@ hscif3: serial@e66a0000 {
> > >                         status = "disabled";
> > >                 };
> > >
> > > +               pciec0: pcie@e65d0000 {
> 
> > > +                       interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                       <0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                       <0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                       <0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>;
> >
> > s/416/449 for all four lines.
> >
> > > +                       snps,enable-cdm-check;
> > > +                       status = "disabled";
> > > +               };
> > > +
> > > +               pciec1: pcie@e65d8000 {
> 
> > > +                       interrupt-map = <0 0 0 1 &gic GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                       <0 0 0 2 &gic GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                       <0 0 0 3 &gic GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                       <0 0 0 4 &gic GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>;
> >
> > s/423/456 for all four lines.
> >
> > > +                       snps,enable-cdm-check;
> > > +                       status = "disabled";
> > > +               };
> 
> Do you foresee more changes, and plan to repost, or can I fix the
> interrupt numbers while applying this series?

Thank you for asking me about this. I intended to repost a fixed patch after PCIe patch series
was merged into PCI subsystem. Otherwise, dtbs_check will detect missing the compatible
"renesas,r8a779g0-pcie" in the dt-binding doc. But, it's under review now [1].

[1] https://patchwork.kernel.org/project/linux-pci/list/?series=844512

Best regards,
Yoshihiro Shimoda

> Thank you!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux