On 19/03/2024 23:42, Niklas Söderlund wrote: > Hi Geert, > > Thanks for your patch. > > On 2024-03-19 17:29:05 +0100, Geert Uytterhoeven wrote: >> Add device nodes for the Timer Units (TMU) on the R-Mobile APE6 SoC, >> and the clocks serving them. >> >> Note that TMU channels 1 and 2 are not added, as their interrupts are >> not wired to the interrupt controller for the AP-System Core (INTC-SYS), >> only to the interrupt controller for the AP-Realtime Core (INTC-RT). >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. DT bindings are separate patches. Best regards, Krzysztof
