Hi Thomas Gleixner, > -----Original Message----- > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Sent: Friday, March 1, 2024 2:16 PM > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Prabhakar Mahadev Lad <prabhakar.mahadev- > lad.rj@xxxxxxxxxxxxxx>; Marc Zyngier <maz@xxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; > biju.das.au <biju.das.au@xxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 4/5] irqchip/renesas-rzg2l: Use TIEN for enable/disable > > On Mon, Feb 12 2024 at 11:37, Biju Das wrote: > > Use TIEN for enable/disable and avoid modifying TINT source selection > > register. > > Why? This will lead to conflict in TINT detection register and TINT source as we are modifying the source. This can also lead to spurious IRQ. > > Changelogs are supposed to explain the WHY and not just decribe the WHAT. OK, will do it in the next version. Cheers, Biju
