On Tue, Jan 30, 2024 at 02:02:12PM +0000, Russell King (Oracle) wrote: > On Tue, Jan 30, 2024 at 02:55:50PM +0100, Andrew Lunn wrote: > > > @@ -768,6 +768,7 @@ struct phy_device { > > > > > > /* Generic phy_device::dev_flags */ > > > #define PHY_F_NO_IRQ 0x80000000 > > > +#define PHY_F_RXC_ALWAYS_ON BIT(30) > > > > It is a bit odd mixing 0x numbers and BIT() macros for the same class > > of thing. I would use 0x40000000, or convert PHY_F_NO_IRQ to BIT(31) > > If I used 0x40000000, there would be review comments suggesting the use > of BIT(). Can't win! No, you cannot win, but at least it would be consistent :-) Andrew