Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Claudiu <claudiu.beznea@xxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <kuba@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <richardcochran@xxxxxxxxx>, <p.zabel@xxxxxxxxxxxxxx>, <geert+renesas@xxxxxxxxx>
Subject: Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
From: Sergey Shtylyov <s.shtylyov@xxxxxx>
Date: Sun, 28 Jan 2024 21:22:51 +0300
Cc: <netdev@xxxxxxxxxxxxxxx>, <linux-renesas-soc@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
In-reply-to: <ada0e1ac-dd33-aad2-52f9-0448b819bc94@omp.ru>
Organization: Open Mobile Platform
References: <20240123125829.3970325-1-claudiu.beznea.uj@bp.renesas.com> <20240123125829.3970325-9-claudiu.beznea.uj@bp.renesas.com> <bb26b1a9-a848-7b5a-26fd-192f004184d8@omp.ru> <ada0e1ac-dd33-aad2-52f9-0448b819bc94@omp.ru>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 1/28/24 9:03 PM, Sergey Shtylyov wrote:
[...]

>>    I suggest the following subject "net: ravb: Move getting/requesting IRQs in
>> the probe() method".

    Or the probe() API, if you prefer this naming...

>    Oops, s/in/to/. :-)

   Well, we don't move getting IRQs to the probe() method, but
we move the platfrom_get_irq[_byname]() calls to a sperate function.
So, pperhaps "in" was good... :-) 

[...]

MBR, Sergey

References:
- [PATCH net-next v4 00/15] net: ravb: Prepare for suspend to RAM and runtime PM support (part 1)
  - From: Claudiu
- [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
  - From: Claudiu
- Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
  - From: Sergey Shtylyov
- Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
  - From: Sergey Shtylyov

Prev by Date: Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
Next by Date: Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
Previous by thread: Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
Next by thread: Re: [PATCH net-next v4 08/15] net: ravb: Move the IRQs get and request in the probe function
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]