Re: [PATCH] net: ravb: Fix wrong dma_unmap_single() calls in ring unmapping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+		if (le16_to_cpu(desc->ds_cc) != 0)

    It's not that != 0 or le16_to_cpu() are necessary here but we're on
the little-endian platforms anyways...

Let's leave optimizing this out to compiler.

In the code, I'd vote for always having explicit conversion operation when reading __le16 value from memory.

Nikita




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux