On 1/12/2024 8:47 PM, Nikita Yushchenko wrote:
When unmapping ring entries on Rx ring release, ravb driver needs to unmap only those entries that have been mapped successfully. To check if an entry needs to be unmapped, currently the address stored inside descriptor is passed to dma_mapping_error() call. But, address field inside descriptor is 32-bit, while dma_mapping_error() is implemented by comparing it's argument with DMA_MAPPING_ERROR constant that is 64-bit when dma_addr_t is 64-bit. So the comparison gets wrong, resulting into ravb driver calling dma_unnmap_single() for 0xffffffff address.
I would still spell out explicitly that a failed mapping from ravb_rx_ring_format_gbeth() and ravb_rx_ring_format_rcar() results in writing the ds_cc descriptor field to 0.
With that fixed and the typo spotted by Sergey, you may add: Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> -- Florian
