On 1/5/24 11:23 AM, Claudiu wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > DBAT setup was done in the driver's probe API. As some IP variants switch > to reset mode (and thus registers content is lost) when setting clocks > (due to module standby functionality) to be able to implement runtime PM > move the DBAT configuration in the driver's ndo_open API. > > This commit prepares the code for the addition of runtime PM. > > Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 946abd7606ca..dbc26c3e95ec 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -1826,6 +1826,7 @@ static int ravb_open(struct net_device *ndev) > napi_enable(&priv->napi[RAVB_NC]); > > ravb_set_delay_mode(ndev); > + ravb_write(ndev, priv->desc_bat_dma, DBAT); Please do consider moving this to ravb_dmac_init(), at least in the future... > > /* Device init */ > error = ravb_dmac_init(ndev); MBR, Sergey
