Hi Claudiu, Thanks for your patch! On Mon, Nov 20, 2023 at 8:01 AM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > Some of the Ethernet pins on RZ/G3S (but also valid for RZ/G2L) need to > have direction of the IO buffer set as output for Ethernet to work > properly. On RZ/G3S these pins are P1_0/P7_0, P1_1/P7_1 with could have > the following Ethernet functions: TXC/TX_CLK or TX_CTL/TX_EN. To be able > to configure this the output enable has been implemented. This is > implemented with 2 per-platform read/write functions to be able to simply > validate the pins supporting this on a platform basis. Moreover, on RZ/G2L > the register though which these settings could be done is 8 bits long > whereas on RZ/G3S this is a 32 bit register. The Ethernet pins supporting > OEN are different. These differences could be handled in platform specific > OEN read/write functions. These registers are documented to support access sizes of 8/16/32 bits on RZ/G3S. Hence you don't need to differentiate, but can just use 8-bit accesses on all platforms. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds