Hi Biju, On Fri, Dec 1, 2023 at 4:02 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > On Fri, Dec 1, 2023 at 12:09 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > wrote: > > > Enable the config for the Renesas DA9062 PMIC and RTC, as it is > > > populated on RZ/G2UL SMARC EVK. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > Thanks for your patch! > > > > LGTM, but I would have expected (at least) > > > > CONFIG_INPUT_DA9063_ONKEY=m > > > > too, cfr. my comments on patch 5/6. > > I have tested this, but I get "da9063-onkey da9062-onkey: error -ENXIO: IRQ ONKEY not found" > So, I won't be able to test onkey events. So plaaning to disable this node. Indeed, currently drivers/input/misc/da9063_onkey.c requires an interrupt to function. I wonder if it can be made to work using a timer and pure polling... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds