Hi Niklas,
Thanks for your patch!
On Fri, Nov 17, 2023 at 5:45 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> The Gen3 gPTP support will be shared between the existing Renesas
Gen4
> Ethernet Switch driver and the upcoming Renesas Ethernet-TSN driver. In
> preparation for this break out the gPTP support to its own module.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> --- a/drivers/net/ethernet/renesas/Kconfig
> +++ b/drivers/net/ethernet/renesas/Kconfig
> @@ -44,7 +44,17 @@ config RENESAS_ETHER_SWITCH
> select CRC32
> select MII
> select PHYLINK
> + select RENESAS_GEN4_PTP
> help
> Renesas Ethernet Switch device driver.
>
> +config RENESAS_GEN4_PTP
> + tristate "Renesas R-Car Gen4 gPTP support"
> + depends on ARCH_RENESAS || COMPILE_TEST
Perhaps
tristate "Renesas R-Car Gen4 gPTP support" if COMPILE_TEST
?
The driver is already auto-selected when needed.
> + select CRC32
> + select MII
> + select PHYLIB
> + help
> + Renesas R-Car Gen4 gPTP device driver.
> +
> endif # NET_VENDOR_RENESAS
> --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> @@ -186,3 +188,6 @@ struct rcar_gen4_ptp_private *rcar_gen4_ptp_alloc(struct platform_device *pdev)
>
> return ptp;
> }
> +EXPORT_SYMBOL_GPL(rcar_gen4_ptp_alloc);
> +
> +MODULE_LICENSE("GPL");
Please add the other MODULE_*() definitions,too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
