Hi Niklas,
On Fri, Nov 17, 2023 at 5:45 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> The gPTP clock is different between R-Car S4 and R-Car V4H. In
> preparation of adding R-Car V4H support define the clock setting.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.h
> +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.h
> @@ -9,8 +9,12 @@
>
> #include <linux/ptp_clock_kernel.h>
>
> -#define PTPTIVC_INIT 0x19000000 /* 320MHz */
> -#define RCAR_GEN4_PTP_CLOCK_S4 PTPTIVC_INIT
> +#define PTPTIVC_INIT_200MHZ 0x28000000 /* 200MHz */
> +#define PTPTIVC_INIT_320MHZ 0x19000000 /* 320MHz */
> +
> +#define RCAR_GEN4_PTP_CLOCK_S4 PTPTIVC_INIT_320MHZ
> +#define RCAR_GEN4_PTP_CLOCK_V4H PTPTIVC_INIT_200MHZ
I think the gPTP Timer Increment Value Configuration value should be
calculated from the module clock rate instead (rsw2 runs at 320 MHz
on R-Car S4, S0D4_HSC and tsn run at 200 MHz on R-Car V4H).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
