Re: [PATCH] clk: renesas: rcar-gen3: Extend SDn divider table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > IIRC, that means that the ATF uses 200MHz for the data channel but
> > disables the 800MHz for the SCC. Because of that, I assume ATF doesn't
> > do tuning then? Isn't that risky to operate at 200MHz without tuning?
> 
> Perhaps these products don't care about using SDHI for booting (i.e. use
> HyperFLASH instead), and thus expect only the application OS (Linux)
> to use SDHI?

Even then, I think ATF needs fixing because it sets up a clock divider
which is not recommended.

> An alternative would be to let cpg_sdh_clk_register() sanitize the
> pre-existing contents of the SD-IFn Clock Frequency Control Register,
> so there would be no need to extend cpg_sdh_div_table[].  An advantage
> of that approach would be that it can handle all invalid combinations,
> not just the few that have been seen in the wild.
> (following the old networking mantra: "be strict when sinding, be
> liberal when receiving').

That sounds very reasonable to me.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux