Hi Morimoto-san,
CC DT
On Tue, Sep 19, 2023 at 3:13 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > > &rcar_sound {
> > > - ports {
> > > - /* rsnd_port0-1 are defined in ulcb.dtsi */
> >
> > Don't you need to add
> >
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > like in the other files?
>
> It is a little bit difficult to understand, but Audio Graph Card dtsi
> relationship is "for ULCB" + "for ULCB-KF".
>
> "for ULCB" side has "#address-cells" and "#size-cells",
> "for ULCB-KF" side adds extra part on it.
I think you misunderstood: ulcb-kf-audio-graph-card-mix+split.dtsi
is the only file that has "ports@1", but does not have the corresponding
"#address-cells = <1>;" and "#size-cells = <0>;" right before it.
You can see this in the output of
"git grep -A4 "&rcar_sound\s{" -- arch/arm64/boot/dts/renesas/ulcb*"
> > > + ports@1 {
> >
> > So now you end up with a "ports" node without a unit address, and a
> > "ports@1" node with a unit address, which looks very strange to me...
>
> It is another part of a little bit difficult part...
> "for ULCB-KF" part needs "for ULCB" part,
> this means "for ULCB" part is used for both "ULCB only dts" and "ULCB-KF dts".
>
> If we uses "ports@1" on "for ULCB" part, dts check will indicates
> extra warning, because it is not needed for "ULCB only dts".
>
> "ULCB dts" needs "ports"
> "ULCB-KF dts" needs "ports@1"
>
> To avoid extra warning, it is using "ports".
Can't you use "ports@0" instead of "ports" in the base DTS?
When there can be multiple subnodes, we usually use unit addresses
for all of them.
> > Same here: "rcar_sound,dai" node without a unit address, and
> > "rcar_sound,dai@1" node with a unit address.
>
> Same above
Full thread at
https://lore.kernel.org/all/87wmwxh4av.wl-kuninori.morimoto.gx@xxxxxxxxxxx
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
