Hi Geert
Thank you for the review
> > + sound_card_kf: expand_sound {
>
> Please no underscores in (new) node names (everywhere)
>
> expand-sound?
OK, will fix in v2 patch
> > &rcar_sound {
> > - ports {
> > - /* rsnd_port0-1 are defined in ulcb.dtsi */
>
> Don't you need to add
>
> #address-cells = <1>;
> #size-cells = <0>;
>
> like in the other files?
It is a little bit difficult to understand, but Audio Graph Card dtsi
relationship is "for ULCB" + "for ULCB-KF".
"for ULCB" side has "#address-cells" and "#size-cells",
"for ULCB-KF" side adds extra part on it.
> > + ports@1 {
>
> So now you end up with a "ports" node without a unit address, and a
> "ports@1" node with a unit address, which looks very strange to me...
It is another part of a little bit difficult part...
"for ULCB-KF" part needs "for ULCB" part,
this means "for ULCB" part is used for both "ULCB only dts" and "ULCB-KF dts".
If we uses "ports@1" on "for ULCB" part, dts check will indicates
extra warning, because it is not needed for "ULCB only dts".
"ULCB dts" needs "ports"
"ULCB-KF dts" needs "ports@1"
To avoid extra warning, it is using "ports".
> Same here: "rcar_sound,dai" node without a unit address, and
> "rcar_sound,dai@1" node with a unit address.
Same above
If it is OK for you, I will post v2 patch
Thank you for your help !!
Best regards
---
Kuninori Morimoto
