RE: [PATCH v2 1/3] arm64: dts: renesas: rzg2ul-smarc-som: Enable serial NOR flash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert Uytterhoeven,

Thanks for the feedback.

> Subject: Re: [PATCH v2 1/3] arm64: dts: renesas: rzg2ul-smarc-som: Enable
> serial NOR flash
> 
> Hi Biju,
> 
> On Thu, Aug 31, 2023 at 8:36 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Enable Renesas at25ql128a flash connected to QSPI0. Also disable the
> > node from rzfive-smarc-som as it is untested.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v1->v2:
> >  * Enabled 4-bit tx support
> 
> Thanks for the update!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-som.dtsi
> > @@ -179,6 +179,18 @@ eth1_pins: eth1 {
> >                          <RZG2L_PORT_PINMUX(18, 5, 1)>; /* IRQ7 */
> >         };
> >
> > +       qspi0_pins: qspi0 {
> > +               qspi0-data {
> > +                       pins = "QSPI0_IO0", "QSPI0_IO1", "QSPI0_IO2",
> "QSPI0_IO3";
> > +                       power-source = <1800>;
> > +               };
> > +
> > +               qspi0-ctrl {
> > +                       pins = "QSPI0_SPCLK", "QSPI0_SSL";
> > +                       power-source = <1800>;
> > +               };
> > +       };
> 
> From the v1 review comments:
> 
> > > I guess there is no need for the subnodes, as all pins use the same
> > > power- source value?
> >
> > OK, will remove subnode.
> 
> Oops...

OK will send V3.

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux