RE: [PATCH] rtc: m41t80: Simplify probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy Shevchenko,

Thanks for the feedback.

> Subject: Re: [PATCH] rtc: m41t80: Simplify probe()
> 
> On Mon, Aug 28, 2023 at 10:27:37AM +0100, Biju Das wrote:
> > Simplify probe() by replacing device_get_match_data() and ID lookup
> > for retrieving match data by i2c_get_match_data().
> 
> ...
> 
> > +	m41t80_data->features = (unsigned long)i2c_get_match_data(client);
> 
> uintptr_t is more natural and de facto pattern for this. Why unsigned long
> is here?

I just used the casting used for of_device_get_match_data.
I will change it to uintptr_t, If there is no objection.

-		m41t80_data->features = (unsigned long)
-			of_device_get_match_data(&client->dev);

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux