Hi Andy Shevchenko, Thanks for the feedback. > Subject: Re: [PATCH] rtc: m41t80: Simplify probe() > > On Mon, Aug 28, 2023 at 10:27:37AM +0100, Biju Das wrote: > > Simplify probe() by replacing device_get_match_data() and ID lookup > > for retrieving match data by i2c_get_match_data(). > > ... > > > + m41t80_data->features = (unsigned long)i2c_get_match_data(client); > > uintptr_t is more natural and de facto pattern for this. Why unsigned long > is here? I just used the casting used for of_device_get_match_data. I will change it to uintptr_t, If there is no objection. - m41t80_data->features = (unsigned long) - of_device_get_match_data(&client->dev); Cheers, Biju
