On Sun, Aug 27, 2023 at 10:45:36AM +0100, Biju Das wrote: > Simplify probe() by replacing of_match_node() and i2c_match_id() with > i2c_get_match_data(). ... > + dev_set_drvdata(&i2c->dev, (void *)i2c_get_match_data(i2c)); You (potentially) drop const qualifier here. It's not good and it's not explained in the commit message why. -- With Best Regards, Andy Shevchenko