RE: [PATCH v19 01/19] PCI: Add INTx Mechanism Messages macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Serge,

> From: Serge Semin, Sent: Wednesday, August 23, 2023 7:18 PM
> 
> On Wed, Aug 23, 2023 at 06:11:35PM +0900, Yoshihiro Shimoda wrote:
> > Add "Message Routing" and "INTx Mechanism Messages" macros to enable
> > a PCIe driver to send messages for INTx Interrupt Signaling.
> >
> > The "Message Routing" is from Table 2-17, and the "INTx Mechanism
> > Messages" is from Table 2-18 on the PCI Express Base Specification,
> > Rev. 4.0 Version 1.0.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > Reviewed-by: Serge Semin <fancer.lancer@xxxxxxxxx>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> >  drivers/pci/pci.h | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> > index a4c397434057..0b6df6c2c918 100644
> > --- a/drivers/pci/pci.h
> > +++ b/drivers/pci/pci.h
> > @@ -13,6 +13,24 @@
> >
> >  #define PCIE_LINK_RETRAIN_TIMEOUT_MS	1000
> >
> > +/* Message Routing (r[2:0]) */
> 
> > +#define PCI_MSG_TYPE_R_ROUTING_RC	0
> > +#define PCI_MSG_TYPE_R_ROUTING_ADDR	1
> > +#define PCI_MSG_TYPE_R_ROUTING_ID	2
> > +#define PCI_MSG_TYPE_R_ROUTING_BC	3
> > +#define PCI_MSG_TYPE_R_ROUTING_LOCAL	4
> > +#define PCI_MSG_TYPE_R_ROUTING_GATHER	5
> 
> I've just noticed. Using "R" and "Routing" simultaneously is
> redundant since "R" means routing. Just "R" would be enough.
> Thus PCI_MSG_TYPE_R_* would mean the R[2:0] subfield of the Message
> (Msg/MsgD) TLPs and we would shorten out the name length.

I'll remove "_ROUTING" from these names on v20.

Best regards,
Yoshihiro Shimoda

> -Serge(y)
> 
> > +
> > +/* INTx Mechanism Messages */
> > +#define PCI_MSG_CODE_ASSERT_INTA	0x20
> > +#define PCI_MSG_CODE_ASSERT_INTB	0x21
> > +#define PCI_MSG_CODE_ASSERT_INTC	0x22
> > +#define PCI_MSG_CODE_ASSERT_INTD	0x23
> > +#define PCI_MSG_CODE_DEASSERT_INTA	0x24
> > +#define PCI_MSG_CODE_DEASSERT_INTB	0x25
> > +#define PCI_MSG_CODE_DEASSERT_INTC	0x26
> > +#define PCI_MSG_CODE_DEASSERT_INTD	0x27
> > +
> >  extern const unsigned char pcie_link_speed[];
> >  extern bool pci_early_dump;
> >
> > --
> > 2.25.1
> >




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux