RE: [PATCH] leds: pca955x: Convert enum->pointer for data in the match tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lee Jones,

> Subject: Re: [PATCH] leds: pca955x: Convert enum->pointer for data in the
> match tables
> 
> On Sun, 20 Aug 2023, Biju Das wrote:
> 
> > Convert enum->pointer for data in the match tables, so that
> > device_get_match_data() can do match against OF/ACPI/I2C tables, once
> > i2c bus type match support added to it.
> >
> > Replace enum->struct *pca955x_chipdefs for data in the match table.
> > Simplify the probe() by replacing device_get_match_data() and ID
> > lookup for retrieving data by i2c_get_match_data().
> >
> > While at it, add const definition to pca955x_chipdefs[].
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > Note:
> >  This patch is only compile tested.
> > ---
> >  drivers/leds/leds-pca955x.c | 45
> > +++++++++++++------------------------
> >  1 file changed, 16 insertions(+), 29 deletions(-)
> 
> This is too big of a change to be added this late in the cycle.
> 
> Especially since this is only compile tested.
> 
> Pushing review until after v6.5 is out.

Fine for me.

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux