Hi all, This patch series contains miscellaneous fixes and improvements for dynamic DT overlays and the related unit tests. The first two patches are fixes for a lock-up and a crash. The remaining patches are smaller fixes, enhancements and cleanups for the overlay tests, including one new test. I ran into the crash when accidentally loading the wrong overlay (using the out-of-tree DT overlay configfs[1]), and removing it afterwards. As this case was not yet covered by the unittests, I added a test. I enhanced the tests to clean up partial state after a failed overlay apply attempt, which triggered the lock-up. Thanks for your comments! [1] https://elinux.org/R-Car/DT-Overlays Geert Uytterhoeven (13): of: dynamic: Do not use "%pOF" while holding devtree_lock of: overlay: Call of_changeset_init() early of: unittest: Fix overlay type in apply/revert check of: unittest: Restore indentation in overlay_bad_add_dup_prop test of: unittest: Improve messages and comments in apply/revert checks of: unittest: Merge of_unittest_apply{,_revert}_overlay_check() of: unittest: Cleanup partially-applied overlays of: unittest: Add separators to of_unittest_overlay_high_level() of: overlay: unittest: Add test for unresolved symbol of: unittest-data: Convert remaining overlay DTS files to sugar syntax of: unittest-data: Fix whitespace - blank lines of: unittest-data: Fix whitespace - indentation of: unittest-data: Fix whitespace - angular brackets drivers/of/dynamic.c | 12 +- drivers/of/overlay.c | 3 +- drivers/of/unittest-data/Makefile | 3 +- drivers/of/unittest-data/overlay.dtso | 32 ++- drivers/of/unittest-data/overlay_0.dtso | 11 +- drivers/of/unittest-data/overlay_1.dtso | 11 +- drivers/of/unittest-data/overlay_11.dtso | 1 - drivers/of/unittest-data/overlay_12.dtso | 11 +- drivers/of/unittest-data/overlay_13.dtso | 11 +- drivers/of/unittest-data/overlay_15.dtso | 1 + drivers/of/unittest-data/overlay_4.dtso | 1 - .../overlay_bad_add_dup_node.dtso | 9 +- .../overlay_bad_add_dup_prop.dtso | 9 +- .../of/unittest-data/overlay_bad_phandle.dtso | 5 +- .../of/unittest-data/overlay_bad_symbol.dtso | 5 +- .../unittest-data/overlay_bad_unresolved.dtso | 7 + drivers/of/unittest-data/overlay_common.dtsi | 36 ++- drivers/of/unittest-data/overlay_gpio_01.dtso | 1 + .../of/unittest-data/overlay_gpio_02a.dtso | 1 + .../of/unittest-data/overlay_gpio_02b.dtso | 1 + drivers/of/unittest-data/overlay_gpio_03.dtso | 1 + .../of/unittest-data/overlay_gpio_04a.dtso | 1 + .../of/unittest-data/overlay_gpio_04b.dtso | 1 + .../of/unittest-data/testcases_common.dtsi | 1 + .../of/unittest-data/tests-interrupts.dtsi | 1 + drivers/of/unittest-data/tests-overlay.dtsi | 1 - drivers/of/unittest-data/tests-phandle.dtsi | 2 + drivers/of/unittest.c | 228 +++++++++++------- 28 files changed, 225 insertions(+), 182 deletions(-) create mode 100644 drivers/of/unittest-data/overlay_bad_unresolved.dtso -- 2.34.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
