Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: Thursday, May 25, 2023 5:07 PM > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Wolfram Sang <wsa@xxxxxxxxxx>; Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx>; Philipp Zabel > <p.zabel@xxxxxxxxxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; Geert Uytterhoeven > <geert+renesas@xxxxxxxxx>; Prabhakar Mahadev Lad <prabhakar.mahadev- > lad.rj@xxxxxxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx; Pavel Machek > <pavel@xxxxxxx> > Subject: Re: [PATCH 2/3] i2c: rzv2m: Rename macro names in all uppercase > > Hi Biju, > > On Thu, May 25, 2023 at 3:51 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Normally we'd put macro names in all uppercase. > > Rename bit_setl->BIT_SETL and bit_clrl->BIT_CLRL. > > > > Reported-by: Pavel Machek <pavel@xxxxxxx> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/i2c/busses/i2c-rzv2m.c > > +++ b/drivers/i2c/busses/i2c-rzv2m.c > > @@ -50,8 +50,8 @@ > > #define IICB0MDSC BIT(7) /* Bus Mode */ > > #define IICB0SLSE BIT(1) /* Start condition output */ > > > > -#define bit_setl(addr, val) writel(readl(addr) | (val), > (addr)) > > -#define bit_clrl(addr, val) writel(readl(addr) & ~(val), > (addr)) > > +#define BIT_SETL(addr, val) writel(readl(addr) | (val), > (addr)) > > +#define BIT_CLRL(addr, val) writel(readl(addr) & ~(val), > (addr)) > > I'd rather change them to static inline functions instead. OK, will change it to static inline fns. Cheers, Biju
