Hi Biju,
On Thu, May 25, 2023 at 3:51 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Normally we'd put macro names in all uppercase.
> Rename bit_setl->BIT_SETL and bit_clrl->BIT_CLRL.
>
> Reported-by: Pavel Machek <pavel@xxxxxxx>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/i2c/busses/i2c-rzv2m.c
> +++ b/drivers/i2c/busses/i2c-rzv2m.c
> @@ -50,8 +50,8 @@
> #define IICB0MDSC BIT(7) /* Bus Mode */
> #define IICB0SLSE BIT(1) /* Start condition output */
>
> -#define bit_setl(addr, val) writel(readl(addr) | (val), (addr))
> -#define bit_clrl(addr, val) writel(readl(addr) & ~(val), (addr))
> +#define BIT_SETL(addr, val) writel(readl(addr) | (val), (addr))
> +#define BIT_CLRL(addr, val) writel(readl(addr) & ~(val), (addr))
I'd rather change them to static inline functions instead.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
