Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH RFC 4/6] dt-bindings: rtc: isl1208: Document built-in
> RTC device on PMIC RAA215300
>
> Hi Biju,
>
> CC Trent's latest address
Thanks, I will fix this in bindings.
>
> On Wed, May 3, 2023 at 10:46 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > The Built-in RTC device found on PMIC RAA215300 is similar to the
> > isl1208 IP. However, RTC is enabled by PMIC RAA215300 and the polarity
> > of the external oscillator is determined by the PMIC revision.
> >
> > Document renesas,raa215300-isl1208 compatible and
> > renesas,raa215300-pmic property to handle these differences.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/rtc/isil,isl1208.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml
> > b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml
> > index 04d51887855f..888a832ed1db 100644
> > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml
> > @@ -18,6 +18,7 @@ properties:
> > - isil,isl1209
> > - isil,isl1218
> > - isil,isl1219
> > + - renesas,raa215300-isl1208
>
> That sounds a bit over-complicated.
> What about just "renesas,raa215300-rtc"?
OK, good to me.
> If you consider them sufficiently compatible, you could add "isil,isl1208"
> as a fallback.
The pmic has to enable RTC block to make it functional.
The registers and functionality are compatible.
But the configuration of Oscillator polarity is different on PMIC version.
So we need to handle it here.
You mean like below?
+ - items:
+ - enum:
+ - renesas, raa215300-rtc
+ - const: isil,isl1208
>
> >
> > reg:
> > maxItems: 1
> > @@ -40,6 +41,10 @@ properties:
> > <0> : Enable internal pull-up
> > <1> : Disable internal pull-up
> >
> > + renesas,raa215300-pmic:
>
> "renesas,pmic"?
OK. Agreed.
Cheers,
Biju
>
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: phandle to the pmic device with isl1208 built-in RTC.
> > +
> > required:
> > - compatible
> > - reg
> > @@ -58,6 +63,14 @@ allOf:
> > - interrupts-extended
> > - interrupt-names
> > - isil,ev-evienb
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,raa215300-isl1208
> > + then:
> > + required:
> > + - renesas,raa215300-pmic
> >
> > unevaluatedProperties: false
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
