On Tue, 2023-03-21 at 15:38 +0100, Wolfram Sang wrote: > > > struct smsc911x_data *pdata = netdev_priv(dev); > > > - struct phy_device *phydev = NULL; > > > + struct phy_device *phydev; > > > int ret; > > > > > > phydev = phy_find_first(pdata->mii_bus); > > > > Nit: perhaps combine this assignment with the variable declaration? > > I thought about it but found this version to be easier readable. This patch does not apply cleanly to net-next, please rebase and resping. Thanks! Paolo
